Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist #100

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

joshpalis
Copy link
Member

Description

Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse the use case template document from the response source

Issues Resolved

Part of #88

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>
@joshpalis joshpalis added the backport 2.x backport PRs to 2.x branch label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #100 (2af5686) into main (c84321f) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #100      +/-   ##
============================================
- Coverage     81.82%   81.46%   -0.37%     
  Complexity      285      285              
============================================
  Files            30       30              
  Lines          1117     1122       +5     
  Branches        125      126       +1     
============================================
  Hits            914      914              
- Misses          158      162       +4     
- Partials         45       46       +1     
Files Coverage Δ
...rk/transport/ProvisionWorkflowTransportAction.java 45.61% <0.00%> (-4.39%) ⬇️

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one comment

@joshpalis joshpalis merged commit 63ef780 into opensearch-project:main Oct 17, 2023
20 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2023
…ument does not exist (#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Oct 17, 2023
…ument does not exist (#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>
joshpalis added a commit that referenced this pull request Oct 17, 2023
… in which a document does not exist (#102)

* Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>

* bumping version to 2.12

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
… in which a document does not exist (opensearch-project#102)

* Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (opensearch-project#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>

* bumping version to 2.12

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
… in which a document does not exist (opensearch-project#102)

* Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (opensearch-project#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>

* bumping version to 2.12

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants